[freetds] .dev.YYYY.mmdd hardcoded docdir?

Discussion:

Frantisek Hanzlik

2014-07-05 09:46:18 UTC

A few days ago I wrote here about problems with bsqldb and fisql;
now I tried build last git2a830b1 version (because my Fedora 19 has
older version 0.91-gitf3ae29d (0a42888 ?) sometimes from November
2013, and I was hoping that new version will be working better).
But I have problem with making FreeTDS RPM package - it seems that
new git version ignore "--docdir" configure option and always install
doc into albeit right "/usr/share/doc/" directory, however here into
"freetds-0.92.dev.YYYYmmdd" (where YYYYmmdd is actual date) - though
I was specifying "--docdir=/usr/share/doc/freetds-0.92".

It is intended, or I'm doing some mistake? IMO docdir (or other
package directories) should not depend on current date, but rather
on version ev. git subversion only }and should be configurable).

Thanks, Franta Hanzlik

Frediano Ziglio

2014-07-06 09:29:58 UTC

Permalink

Confirmed, at
https://gitorious.org/freetds/freetds/source/8780c1f243abef142756bb9caf0062196d48b9d7:doc/Makefile.am#L9-17
TARGET_DOCDIR uses $(datadir) (which is usually /usr/share) so the problem.

I'm not sure however about --docdir. Should it point to main root (like
/usr/share/doc) or specific to project?

I think you are referring to configure option, in configure I have

docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'

I think we don't use this as we want to embed the version to this directory
however looking at my /usr/share/doc directory there is no versions but
only package name so perhaps the target we use is not right.

Our spec file say

The freetds-doc package contains the useguide and reference of FreeTDS
and can be installed even if FreeTDS main package is not installed

But this does not say we should be able to install different versions

Frediano

Post by Frantisek Hanzlik
A few days ago I wrote here about problems with bsqldb and fisql;
now I tried build last git2a830b1 version (because my Fedora 19 has
older version 0.91-gitf3ae29d (0a42888 ?) sometimes from November
2013, and I was hoping that new version will be working better).
But I have problem with making FreeTDS RPM package - it seems that
new git version ignore "--docdir" configure option and always install
doc into albeit right "/usr/share/doc/" directory, however here into
"freetds-0.92.dev.YYYYmmdd" (where YYYYmmdd is actual date) - though
I was specifying "--docdir=/usr/share/doc/freetds-0.92".
It is intended, or I'm doing some mistake? IMO docdir (or other
package directories) should not depend on current date, but rather
on version ev. git subversion only }and should be configurable).
Thanks, Franta Hanzlik
_______________________________________________
FreeTDS mailing list
FreeTDS at lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds

James K. Lowden

2014-07-07 04:12:27 UTC

Permalink

On Sun, 6 Jul 2014 11:29:58 +0200

Post by Frediano Ziglio
I'm not sure however about --docdir. Should it point to main root
(like /usr/share/doc) or specific to project?
I think you are referring to configure option, in configure I have
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'

Hi Freddy,

I think the HTML install location was overengineered way back when.
ISTM it should be just

docdir='${datarootdir}/doc/freetds'

for the same reason that the libraries are installed in PREFIX/lib:
Only one version is installed, and only one version of the
documentation need be installed.

Nowadays autoconf supports htmldir, which seems more appropriate.

Mea culpa. I plead youthful exuberance and lack of elders to guide me.

--jkl

Frediano Ziglio

2014-07-13 16:10:40 UTC

Permalink

Post by James K. Lowden
On Sun, 6 Jul 2014 11:29:58 +0200

Hi Freddy,
I think the HTML install location was overengineered way back when.
ISTM it should be just
docdir='${datarootdir}/doc/freetds'
Only one version is installed, and only one version of the
documentation need be installed.
Nowadays autoconf supports htmldir, which seems more appropriate.
Mea culpa. I plead youthful exuberance and lack of elders to guide me.

Fixed in master branch.

Frediano

Frantisek Hanzlik

2014-07-13 15:53:54 UTC

Permalink

It seems as Fedora distros specify "configure" --docdir as
"/usr/share/doc" (without package name) - as You say,
it point to "main root".
Then they puts package docs into %{packagename}-%{version}/
subdirectory - but it is distro own policy (moreover, Fedora
from release 20 did "Unversioned Docdirs" and packages docs
are in "/usr/share/doc/%{packagename}" (without version).
This convention was backported also to Fedora 18 and 19.

Franta Hanzlik

Post by Frediano Ziglio
Confirmed, at
https://gitorious.org/freetds/freetds/source/8780c1f243abef142756bb9caf0062196d48b9d7:doc/Makefile.am#L9-17
TARGET_DOCDIR uses $(datadir) (which is usually /usr/share) so the problem.
I'm not sure however about --docdir. Should it point to main root (like
/usr/share/doc) or specific to project?
I think you are referring to configure option, in configure I have
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
I think we don't use this as we want to embed the version to this directory
however looking at my /usr/share/doc directory there is no versions but
only package name so perhaps the target we use is not right.
Our spec file say
The freetds-doc package contains the useguide and reference of FreeTDS
and can be installed even if FreeTDS main package is not installed
But this does not say we should be able to install different versions
Frediano

Frediano Ziglio

2014-07-13 16:19:28 UTC

Permalink

Can you try to compile our package using Fedora ?

I usually use "rpmbuild -ta freetds-0.XXXXX.tar.bz2"

Frediano

Post by Frantisek Hanzlik
It seems as Fedora distros specify "configure" --docdir as
"/usr/share/doc" (without package name) - as You say,
it point to "main root".
Then they puts package docs into %{packagename}-%{version}/
subdirectory - but it is distro own policy (moreover, Fedora
from release 20 did "Unversioned Docdirs" and packages docs
are in "/usr/share/doc/%{packagename}" (without version).
This convention was backported also to Fedora 18 and 19.
Franta Hanzlik

Post by Frediano Ziglio
Confirmed, at

https://gitorious.org/freetds/freetds/source/8780c1f243abef142756bb9caf0062196d48b9d7:doc/Makefile.am#L9-17

Post by Frediano Ziglio
TARGET_DOCDIR uses $(datadir) (which is usually /usr/share) so the

problem.

Post by Frediano Ziglio
I'm not sure however about --docdir. Should it point to main root (like
/usr/share/doc) or specific to project?
I think you are referring to configure option, in configure I have
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
I think we don't use this as we want to embed the version to this