[freetds] [PATCH] bashisms prevent build in doc/Makefile

Discussion:

arielCo

2013-06-20 17:23:04 UTC

There are a few bash-isms in doc/Makefile.am that prevent build (which
specifies SHELL = /bin/sh). Things like " NAME=$$(echo $@ | sed
's/\..*$$//') ".

The attached patch fixes them (based on the tarball from
http://gitorious.org/freetds/freetds/trees/master). Maybe all
Makefiles should use /bin/sh?

Ariel Cornejo
+58?412?8083546
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.am.patch
Type: application/octet-stream
Size: 1292 bytes
Desc: not available
Url : http://lists.ibiblio.org/pipermail/freetds/attachments/20130620/f5bfce3e/attachment.obj

Frediano Ziglio

2013-06-20 21:53:59 UTC

Permalink

Applied!

Thanks.

I would ask why this file set shell. Don't really know, change was 9f107033
where a doc/Makefile was converted to doc/Makefile.am

2013/6/20 arielCo <arielco at gmail.com>

Post by arielCo
There are a few bash-isms in doc/Makefile.am that prevent build (which
's/\..*$$//') ".
The attached patch fixes them (based on the tarball from
http://gitorious.org/freetds/freetds/trees/master). Maybe all
Makefiles should use /bin/sh?
Ariel Cornejo
+58?412?8083546
_______________________________________________
FreeTDS mailing list
FreeTDS at lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds

arielCo

2013-06-20 22:05:02 UTC

Permalink

Actually that's the only Makefile.am that defines SHELL. The rest use
the value of $SHELL from the environment, so any other bash-isms would
be concealed since most users run bash or ksh.

Ariel Cornejo
+58?412?8083546

Post by Frediano Ziglio
Applied!
Thanks.
I would ask why this file set shell. Don't really know, change was 9f107033
where a doc/Makefile was converted to doc/Makefile.am
2013/6/20 arielCo <arielco at gmail.com>

_______________________________________________
FreeTDS mailing list
FreeTDS at lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds